From delete buckets operation's metrics, remove `error_write_count` and `error_read_count` for I/O metrics.

[sanvidhansonone]

Environment info

• NooBaa Version: VERSION
• Platform: OpenShift Data Foundation 4.12.0

ODF Operator: 4.12.0
ODF Operator Image: quay.io/rhceph-dev/odf4-odf-rhel8-operator@sha256:64ad5456e46e04551488c0e0a3c10f02d6d1bef9a4e0273347b82acab9e8c101
Noobaa Core Image: quay.io/rhceph-dev/odf4-mcg-core-rhel8@sha256:d4c5835811499197cc171ac81b0f2ed3d7d732773c8bdeba49598513d75a93b6
Noobaa Operator Image: quay.io/rhceph-dev/odf4-mcg-rhel8-operator@sha256:16ef22df996c4f77e63761a96b843a74da35023af2c33ec1e0b72f16d7c81fd8

Steps to reproduce

1. Create multiple buckets with s3 mb command
2. Delete bucket using s3 rb command
3. Check metrics, for delete buckets operation (after 60sec)

More information - Screenshots / Logs / Other output

Metrics after deleting buckets

noobaa_nsfs_read_count: 0
noobaa_nsfs_write_count: 0
noobaa_nsfs_read_bytes: 0
noobaa_nsfs_write_bytes: 0
noobaa_nsfs_error_write_bytes: 0
noobaa_nsfs_error_write_count: 0
noobaa_nsfs_error_read_bytes: 0
noobaa_nsfs_error_read_count: 0

noobaa_nsfs_delete_bucket_min_time_milisec: 288
noobaa_nsfs_delete_bucket_max_time_milisec: 3883
noobaa_nsfs_delete_bucket_avg_time_milisec: 1509
noobaa_nsfs_delete_bucket_count: 3
noobaa_nsfs_delete_bucket_error_count: 0

noobaa_nsfs_stat_min_time_microsec: 10
noobaa_nsfs_stat_max_time_microsec: 16062
noobaa_nsfs_stat_avg_time_microsec: 6875
noobaa_nsfs_stat_count: 6
noobaa_nsfs_stat_error_count: 0

noobaa_nsfs_realpath_min_time_microsec: 19
noobaa_nsfs_realpath_max_time_microsec: 122
noobaa_nsfs_realpath_avg_time_microsec: 70
noobaa_nsfs_realpath_count: 3
noobaa_nsfs_realpath_error_count: 0

noobaa_nsfs_checkaccess_min_time_microsec: 33
noobaa_nsfs_checkaccess_max_time_microsec: 79
noobaa_nsfs_checkaccess_avg_time_microsec: 61
noobaa_nsfs_checkaccess_count: 3
noobaa_nsfs_checkaccess_error_count: 0

noobaa_nsfs_readdir_min_time_microsec: 25
noobaa_nsfs_readdir_max_time_microsec: 24596
noobaa_nsfs_readdir_avg_time_microsec: 4153
noobaa_nsfs_readdir_count: 6
noobaa_nsfs_readdir_error_count: 0

noobaa_nsfs_rmdir_min_time_microsec: 5145
noobaa_nsfs_rmdir_max_time_microsec: 22344
noobaa_nsfs_rmdir_avg_time_microsec: 15840
noobaa_nsfs_rmdir_count: 3
noobaa_nsfs_rmdir_error_count: 0

[liranmauda]

Thanks @sanvidhansonone
that is true.

noobaa_nsfs_error_write_bytes: 0
noobaa_nsfs_error_write_count: 0
noobaa_nsfs_error_read_bytes: 0
noobaa_nsfs_error_read_count: 0

is left over from an old code and it will never be updated.
I will remove that completely as it seems it has no value.