NSFS | Adding metric type to the prefix + Removing the errors in the nsfs io count

[liranmauda]

Explain the changes

• Removing read and write error count for NSFS I/O metrics
• If the namespace count does have some error prompting a warning. just that we will be aware and consider re-adding it
• Adding to the NSFS metrics report the metric type (fs/op/io)

Signed-off-by: liranmauda liran.mauda@gmail.com

Issues: Fixed #xxx / Gap #xxx

1. Fixes: From delete buckets operation's metrics, remove error_write_count and error_read_count for I/O metrics. #7188
2. Fixes: metrics params name should be identical, for I/O Ops, S3Ops, and FS Ops #7190

Testing Instructions:

1. Create an NSFS bucket
2. Upload files
3. Check the metrics in /metrics/nsfs_stats

[liranmauda]

There are 2 commits intentionally.

[shirady]

I think that we should not leave code in comments in general.
If we would get here and need to debug it - we have version control.

If you insist on leaving them, at least I would suggest also leaving a comment here about why we added the code in a comment explicitly. For example:

Uncomment these lines in case we see the warning above in the logs.
I left them to help us debug it easily.
We can delete them if we will see that we don't have the warning above for a while.

@liranmauda, What do you think?

[liranmauda]

The warning itself is the explanation.
here we will probably never reach the error path as it is in under layer, and the error will fail much earlier.
with that said, this code is relaying on an older code, and for the chance that we are missing a flow, we added the warning to explain and to see that we actually moved throw this flow.

once we get confidante we can remove the condition completely (the whole if, else will not be relevant).