Skip to content

Remove outdated TODO for tag_name + class_name matching in WP_HTML_Processor - #71

Closed
josephfusco with Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-class-name-tag-matching
Closed

Remove outdated TODO for tag_name + class_name matching in WP_HTML_Processor#71
josephfusco with Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-class-name-tag-matching

Conversation

@Claude

@Claude Claude AI commented Apr 9, 2026

Copy link
Copy Markdown

Description

The TODO at line 676 in class-wp-html-processor.php stated "Support matching the class name and tag name" but the functionality was already fully implemented. The next_tag() method extracts both tag_name and class_name from the query array and validates them together (lines 729-745, 763-765).

Changes

  • Removed outdated TODO comment from src/wp-includes/html-api/class-wp-html-processor.php
  • Added test test_next_tag_matches_tag_name_and_class_name() in tests/phpunit/tests/html-api/wpHtmlProcessor.php verifying:
    • Combined tag_name + class_name matching skips non-matching elements
    • Each filter works independently
    • Multiple matches iterate correctly

Testing

New test validates the query behavior:

$processor->next_tag(
    array(
        'tag_name'   => 'div',
        'class_name' => 'header',
    )
);
// Skips <span class="header"> and <div class="footer">
// Finds only <div class="header"> elements

AI Disclosure

  • AI-authored: Yes
  • Agent: Claude Code
  • Model: Claude Sonnet 4.5

Governance Checklist

  • Code follows WordPress coding standards
  • Tests are included for all changes
  • No upstream CI workflows were modified
  • GOVERNANCE.md rules have been followed
  • PR has appropriate type: label

This repository is governed by GOVERNANCE.md. PRs are auto-merged when governance conditions are met.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/PHPCSStandards/PHPCSExtra/zipball/b598aa890815b8df16363271b659d73280129101
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCSStandards/PHPCSUtils/zipball/c216317e96c8b3f5932808f9b0f1f7a14e3bbf55
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0ca86845ce43291e8f5692c7356fccf3bcf02bf4
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCompatibility/PHPCompatibility/zipball/9fb324479acf6f39452e0655d2429cc0d3914243
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCompatibility/PHPCompatibilityParagonie/zipball/244d7b04fc4bc2117c15f5abe23eb933b5f02bbf
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/PHPCompatibility/PHPCompatibilityWP/zipball/7c8d18b4d90dac9e86b0869a608fa09158e168fa
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/WordPress/WordPress-Coding-Standards/zipball/7795ec6fa05663d716a549d0b44e47ffc8b0d4a6
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/Yoast/PHPUnit-Polyfills/zipball/41aaac462fbd80feb8dd129e489f4bbc53fe26b0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/composer/ca-bundle/zipball/961a5e4056dd2e4a2eedcac7576075947c28bf63
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/doctrine/instantiator/zipball/c6222283fa3f4ac679f8b9ced9a4e23f163e80d0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/phpstan/phpstan/zipball/c6f73a2af4cbcd99c931d0fb8f08548cc0fa8224
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/2b56bea83a09de3ac06bb18b92f068e60cc6f50b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/code-unit-reverse-lookup/zipball/ac91f01ccec49fb77bdc6fd1e548bc70f7faa3e5
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/code-unit/zipball/1fc9f64c0927627ef78ba436c9b17d967e68e120
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/comparator/zipball/e4df00b9b3571187db2831ae9aada2c6efbd715d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/complexity/zipball/25f207c40d62b8b7aa32f5ab026c53561964053a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/diff/zipball/ba01945089c3a293b01ba9badc29ad55b106b0bc
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/environment/zipball/830c43a844f1f8d5b7a1f6d6076b784454d8b7ed
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/exporter/zipball/14c6ba52f95a36c3d27c835d65efc7123c446e8c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/global-state/zipball/b6781316bdcd28260904e7cc18ec983d0d2ef4f6
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/lines-of-code/zipball/e1e4a170560925c26d424b6a03aed157e7dcc5c5
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/5c9eeac41b290a3712d88851518825ad78f45c71
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/b4f479ebdbf63ac605d183ece17d8d7fe49c15c7
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/85402a822d1ecf1db1096959413d35e1c37cf1a5
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/cf1c2e7c203ac650e352f4cc675a7021e7d1b3cf
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/5a10147d0aaf65b58940a0b72f71c9ac0423cc67
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/5da5f67fc95621df9ff4c4e5a84d6a8a2acf7c28
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/php-timer/zipball/5a63ce20ed1b5bf577850e2c4e87f4aa902afbd2
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/phpunit/zipball/b36f02317466907a230d3aa1d34467041271ef4a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/539c6691e0623af6dc6f9c20384c120f963465a0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/resource-operations/zipball/05d5692a7993ecccd56a03e40cd7e5b09b1d404e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/75e2c2a32f5e0b3aef905b9ed0b179b953b3d7c7
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/c6c1022351a901512170118436c764e473f6de8c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)
  • https://api.github.com/repos/theseer/tokenizer/zipball/b7489ce515e168639d17feec34b8847c326b0b3c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/kKm8wj /usr/bin/composer install --no-interaction /usr/bin/head (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/eX2E46 /usr/bin/composer install --no-interaction de/node/bin/git t-Polyfills.git/git base64 /usr/bin/base64 e/git rev-�� --quiet --verify } tained-and-connebase64 git k/_temp/ghcca-node/node/bin/git git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@Claude Claude AI changed the title [WIP] Fix TODO for matching class name and tag name in WP HTML processor Remove outdated TODO for tag_name + class_name matching in WP_HTML_Processor Apr 9, 2026
@Claude
Claude AI requested a review from josephfusco April 9, 2026 03:09
@github-actions github-actions Bot added the safety:halt Circuit breaker active label Apr 9, 2026
@josephfusco
josephfusco marked this pull request as ready for review April 9, 2026 05:00
@josephfusco
josephfusco requested a review from a team as a code owner April 9, 2026 05:00
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @claude.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nopilots-doc

nopilots-doc Bot commented Apr 9, 2026

Copy link
Copy Markdown

Doc (Code Quality):

The removal of the outdated TODO comment at line 676 is appropriate since the functionality is indeed implemented. However, ensure that the comment's removal does not obscure the historical context for future maintainers. The newly added test test_next_tag_matches_tag_name_and_class_name() is thorough, covering various scenarios for the next_tag() method, which enhances code reliability.

No specific readability issues were noted, but ensure that any future comments are clear and concise to maintain understanding.

READABILITY: PASS — The code is clear and maintains a logical structure.
PHPDOC: PASS — The PHPDoc comments are present and correctly describe the functionality.
COMPLEXITY: PASS — The changes do not introduce unnecessary complexity.
TESTS: PASS — Comprehensive tests have been added to cover the new functionality.
STYLE: PASS — The code adheres to the established coding standards.

@nopilots-dalton

Copy link
Copy Markdown

Dalton (Security):

The changes in this pull request involve removing an outdated comment and adding tests for the next_tag() method in the WP_HTML_Processor class. The core functionality appears to be intact and is focused on matching HTML tags and class names.

  1. INPUT_SANITIZATION: PASS — The next_tag() method extracts tag_name and class_name from the query array and validates them. The test cases do not introduce any new input methods or user-supplied data that could be exploited.

  2. OUTPUT_ESCAPING: N/A — There are no changes to output rendering or escaping in this diff.

  3. SQL_PREPARATION: N/A — There are no database interactions or SQL queries in this diff.

  4. CAPABILITY_CHECKS: N/A — No changes to user capabilities or permissions are present in this diff.

  5. NONCE_VERIFICATION: N/A — There are no changes related to nonce verification in this diff.

  6. ATTACK_SURFACE: PASS — The changes do not introduce any new attack vectors. The focus is on validating existing functionality without exposing new vulnerabilities.

Overall, this PR does not introduce any security concerns based on the changes made.

INPUT_SANITIZATION: PASS — The input to `next_tag()` is validated.
OUTPUT_ESCAPING: N/A — No output changes.
SQL_PREPARATION: N/A — No SQL interactions.
CAPABILITY_CHECKS: N/A — No capability changes.
NONCE_VERIFICATION: N/A — No nonce changes.
ATTACK_SURFACE: PASS — No new attack vectors introduced.

@nopilots-pat nopilots-pat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pat (Compatibility + Decision):

The changes in this PR focus on removing an outdated comment and adding tests without altering any public interfaces or functionality. Both Doc and Dalton's reviews confirm that the code quality and security aspects are intact. There are no compatibility issues present in the diff.

FUNCTION_SIGNATURES: PASS — No changes to public function signatures.
HOOK_COMPATIBILITY: PASS — No changes to hooks.
RETURN_TYPES: PASS — No changes to return types.
DEPRECATION_PATH: PASS — No deprecations to address.
DECISION: APPROVE
RATIONALE: The PR maintains compatibility and enhances test coverage without introducing any breaking changes.

DECISION: APPROVE

@josephfusco josephfusco removed the safety:halt Circuit breaker active label Apr 9, 2026
@github-actions
github-actions Bot enabled auto-merge (squash) April 9, 2026 13:27
@josephfusco

Copy link
Copy Markdown

Closing: open 4+ days with no approval or iteration. Pipeline cleanup 2026-04-13.

auto-merge was automatically disabled April 13, 2026 15:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address TODO in wp-includes/html-api/class-wp-html-processor.php: Support matching the class name and tag name.

2 participants