Skip to content

feat(modal): add ability to press escape or click outside to close modal#1198

Merged
DalderupMaurice merged 2 commits intodevelopfrom
feature/click-outside
Oct 19, 2019
Merged

feat(modal): add ability to press escape or click outside to close modal#1198
DalderupMaurice merged 2 commits intodevelopfrom
feature/click-outside

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Oct 19, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2019

Codecov Report

Merging #1198 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1198   +/-   ##
=======================================
  Coverage     49.9%   49.9%           
=======================================
  Files          248     248           
  Lines         2120    2120           
  Branches       282     282           
=======================================
  Hits          1058    1058           
  Misses         884     884           
  Partials       178     178

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Oct 19, 2019
@DalderupMaurice DalderupMaurice merged commit 0899d38 into develop Oct 19, 2019
@DalderupMaurice DalderupMaurice deleted the feature/click-outside branch October 19, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant