fix(security): Account/AuthResult/RawMiAuthResponse の Debug 実装から token を redact#32
Merged
Merged
Conversation
…n を redact
derive(Debug) のままだと {:?} でログや panic メッセージに平文トークンが
漏れるため、token フィールドを <redacted> に伏せる手書き Debug 実装に
置き換える。Drop での zeroize は既にあるが、生存中のログ出力経路が
無防備だった (notedeck-dev/notedeck#780)。
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
notedeck-dev/notedeck#780 の一環。
derive(Debug)のままだと{:?}でログや panic メッセージに平文トークンが漏れる。Dropでのzeroizeはあるが、生存中のログ出力経路が無防備だった。変更
Account/AuthResult/RawMiAuthResponseのDebugを手書き実装にし、token を<redacted>に伏せるformat!("{:?}")に平文が含まれないこと）🤖 Generated with Claude Code