move note ux + new feature section#649
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small but nice set of changes around the move note flow and keeping the landing page in sync with what the app actually does.
what changed
MoveNoteDialog.tsxswapped the
router.pushbutton inside the toast for anIntentPrefetchLink— so now when you move a note and hit "checkout" in the toast, it uses the prefetch link instead of a plain imperative navigation. the layout stuff (flex,items-center,gap-2) moved inside the link where it belongs.FeaturesSection.tsxadded the "move your stuff" video to the feature videos map so the landing page actually shows a demo for it.
lib/data.tsadded "move your stuff" as a proper entry in the
Featuresarray with a description and theFileSymlinkicon — now it shows up on the landing page like the rest of the features.why
the move note feature existed in the app but wasn't represented on the landing page at all — no feature card, no video, nothing. also the toast's "checkout" button was doing an imperative push which skips any prefetching benefits we get from the intent link.
what's better now