search dialog major changes adding workspace tree view#658
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
big rework of the search dialog. instead of a flat time-grouped list of notes, search now shows a proper workspace → table → note hierarchy. and both the search dialog and the move note dialog now share the same backend query.
what changed
convex/notes.tsgetMoveTargetsrenamed togetWorkspaceTree+ notes includedthe query now fetches notes for every table (minus the heavy
bodyfield) and returns the full tree. filtering logic was also improved it now matches on workspace name, table name, and note title, and only drops tables/workspaces that have zero matching results.SearchDialog.tsxcomplete rewrite of the results viewusePaginatedQuery+ time-grouped layout entirelyuseQuery(api.notes.getWorkspaceTree)same query as move dialogWorkspaceTreecomponent that renders the workspace → table → note hierarchy with collapsible workspace rowsgroupNotesByTimehelper that's no longer neededNoteItemnow supports anindentedprop for the nested tree layoutMoveNoteDialog.tsxupdated to usegetWorkspaceTreeswapped the
getMoveTargetscalls togetWorkspaceTreeand updated the background color tobg-mutedfor consistency.currentbadge also updated to use secondary theme tokens.why
the flat time-based list made it hard to understand where a note actually lives. the workspace tree gives way more context at a glance, and letting the user search by workspace or table name makes finding things a lot faster. it also made sense to consolidate the two dialogs onto one shared query instead of maintaining two similar ones.
what's better now