revert feature title back to Stuff, dead code cleanup, safe video lookup#666
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
lib/data.tstitle reverted"Move Your Notes" is back to "Move Your Stuff" to match the
featureVideoskey inFeaturesSection.tsx. also trimmed the trailing space from the description.lib/data.tsdead code removeddeleted
poweredBy,testimonials1, andtestimonials2all unused arrays that were just sitting there.FeaturesSection.tsxsafe video lookupadded a null check before destructuring
featureVideos[feature.title]. if a feature doesn't have a matching video entry it now returnsnullinstead of throwing, which prevents the crash that would have happened with the title rename from the last pr.why
the title rename broke the video map key lookup. this restores the title, adds a guard so future mismatches don't crash the page, and clears out dead data arrays at the same time.