Skip to content

refactor ui: improve button hover states and dropdown borders #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moehdotdev merged 1 commit into from
Apr 28, 2026
Merged

refactor ui: improve button hover states and dropdown borders #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/home/[id]/WorkingSpacePageClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,10 @@ export function NotesDroppableContainer({
<Button
variant="SidebarMenuButton"
size="sm"
className={cn("rounded-none", viewMode === "grid" && "bg-muted")}
className={cn(
"rounded-none hover:bg-muted",
viewMode === "grid" && "bg-muted",
)}
onClick={() => setViewMode("grid")}
>
<LayoutGrid
Expand All @@ -840,7 +843,10 @@ export function NotesDroppableContainer({
<Button
variant="SidebarMenuButton"
size="sm"
className={cn("rounded-none", viewMode === "list" && "bg-muted")}
className={cn(
"rounded-none hover:bg-muted",
viewMode === "list" && "bg-muted",
)}
onClick={() => setViewMode("list")}
>
<List
Expand Down
6 changes: 3 additions & 3 deletions components/ui/dropdown-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const DropdownMenuSubContent = React.forwardRef<
<DropdownMenuPrimitive.SubContent
ref={ref}
className={cn(
"z-50 min-w-[8rem] overflow-hidden rounded-lg border border-primary/10 bg-muted p-1 text-muted-foreground shadow-lg data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
"z-50 min-w-[8rem] overflow-hidden rounded-lg border border-border bg-muted p-1 text-muted-foreground shadow-lg data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
className,
)}
{...props}
Expand All @@ -65,7 +65,7 @@ const DropdownMenuContent = React.forwardRef<
ref={ref}
sideOffset={sideOffset}
className={cn(
"z-50 w-full overflow-hidden bg-card border border-primary/10 rounded-lg p-1 text-foreground ",
"z-50 w-full overflow-hidden bg-card border border-border rounded-lg p-1 text-foreground ",
"data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
className,
)}
Expand Down Expand Up @@ -163,7 +163,7 @@ const DropdownMenuSeparator = React.forwardRef<
>(({ className, ...props }, ref) => (
<DropdownMenuPrimitive.Separator
ref={ref}
className={cn("-mx-1 my-1 h-px bg-primary/20", className)}
className={cn("-mx-1 my-1 h-px bg-border", className)}
{...props}
/>
));
Expand Down