card open btns redesigned,inline edit border tokens, misc cleanup#713
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
open buttons on workspace/note cards
replaced the ghost
h-7open buttons with the default button variant anchored to the bottom-right corner of the card footer —absolute bottom-0 right-0 h-9with the same lift-shadow hover effect used elsewhere in the app (hover:translate-x-[-2px] hover:translate-y-[-2px] hover:shadow-[2px_2px_0px]). applies toWorkspaceCard,NoteCard,GridNoteCard, andListNoteCard.inline edit borders
all inline rename inputs and hover borders changed from
border-primary/20/border-primary/50toborder-muted-foregroundfor consistency.GridNoteCardcard background changed from
bg-card/90tobg-card(full opacity).view mode toggle buttons
added
!rounded-none(with!important) to override theapp-radius-lgbase class so the grid/list toggle buttons stay truly square.NoteSettings.tsxremoved the custom
hover:bg-primary/10from the Download submenu trigger since the dropdown component now handles hover styles.WorkingSpaceSettings.tsxdelete button trash icon changed from
text-primarytotext-muted-foreground.dropdown-menu.tsxsub-trigger focus/open state changed from
focus:bg-primary/10 data-[state=open]:bg-primary/10tofocus:bg-border data-[state=open]:bg-border. also fixed indentation onDropdownMenuContent.why
the old ghost open buttons were visually weak and didn't feel clickable. anchoring them to the corner with the consistent lift effect makes them feel like part of the card's design language.