image click-to-expand +add-block btn + editor shell css+some reverts#738
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
advanced-editor.tsximage click-to-expandadded
handleClickOntoeditorPropswhen an already-selected image node is clicked, it opens a dialog showing the image at full size. aDialogcomponent is rendered below the editor andimagePreviewSrcstate drives it. the image getsmax-h-[80vh] object-containso it fits the viewport.advanced-editor.tsxdrag handle + block insertwrapped the drag handle dots in a container that also shows a
+button to the left. clicking+inserts a paragraph with"/"at the position below the current block, which triggers the slash command menu. usesinsertContentAt+setTextSelectionto place the cursor in the right spot.extensions.tsimage cursor and transitionadded
cursor-zoom-in transition-shadow duration-200to the image html attributes so users get a visual cue that clicking will expand the image.globals.css.advanced-editor-shelladded css for the
advanced-editor-shellclass: normalizes--moveable-colorfor the image resize handle and setsProseMirror-selectednodeborder to transparent (removing the default blue outline on selected images since the moveable control box handles that).selecter resizer that match the theme

WorkingSpacePageClient.tsxworkspace header card changed from
rounded-none rounded-tl-lg rounded-br-lgtoapp-radius-md.NotePageClient.tsx+public/document/[id]/page.tsxrevertedparseTiptapContentreverted back to plain
JSON.parsewith try/catch. theparseTiptapContentabstraction was removed from these call sites.