pdf pinning, thumbnails panel, and sidebar uploads#749
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed (fun stuff)
pinned pdfs
favoritefield to the pdfs schema so uploads can be pinned just like notesupdatePdfnow acceptsfavoriteas an optional argPinnedUploadsList+PinnedUploadItemcomponents in the sidebar, with the same double-click-to-rename and lazy-load-more behavior as pinned notesgetFavPdfspaginated query fetches only the user's pinned pdfspdf settings panel
PdfCardMenuout and replaced it with a sharedPdfSettingscomponent used in three places: grid card, list card, and the top header bar when you're viewing a pdfPdfSettingsSidebarused in the sidebar pinned itemthumbnails panel in the pdf viewer
ThumbnailsPanelsidebar in the viewer, toggled with a "Pg" button in the toolbar"search" | "thumbnails" | null) instead of a boolean, so search and thumbnails are mutually exclusiveusePdfstate handles current page directly nowfixed right-4 top-20so it doesn't overlap the side panelsdrop upload idempotency
GlobalFolderDropUploadnow callsgetOrCreateTableinstead ofcreateTable, so dropping files into a workspace that already has a "uploads" table won't create a duplicatelayout fixes
min-h-0so the pdf viewer can fill the full height without overflowingPdfSettingsSidebaradded toAppSidebarimportsmovePdfmutation for moving a pdf between workspaces/tables (backend only for now)