move dialog redesign and color consistency#752
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
move note/pdf dialog layout rework
MoveNoteDialogandMovePdfDialoggot the same treatment, so they're visually in sync nowrelativewith an absolutely positioned verticalw-px bg-borderline running from below the workspace header down through its table list gives a clear visual tree structure showing which tables belong to which workspace<button>became a<div>wrapper, and the clickable<button>inside getsmx-4indent andpx-2 py-2padding, so the hover/active area is properly inset and aligned with the tree lineml-4 h-px w-3horizontal connector span that was sitting between the indent and the folder icon the vertical line handles the hierarchy now and the connector felt redundantbg-primary/10tohover:bg-border/bg-mutedso they use semantic tokens instead of tinted primary colors, which looks better in both light and dark themesh-8toh-7to better match the compact density of the table rowscolor consistency across both dialogs
text-primary/70totext-foreground— it was too faint and didn't need the primary tinttext-primary/70totext-muted-foregroundtext-primary/50totext-muted-foregroundtext-primary/60andtext-primary/80totext-muted-foregroundconsistent with how icons look everywhere else in the appborder-primary/10toborder-transparentso there's no phantom colored border on non-hovered rowsfeedback dialog submit button
absolute -bottom-6 -right-6inside arelative pb-6footer visually tucks it into the bottom-right corner of the dialog for a more intentional layout rather than the default footer flowwhy
primary/Nopacity colors were inconsistent with the rest of the ui and made the dialogs look different depending on the theme