floating header and scroll fade cleanup#757
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
header now floats over content
z-[10]) changed fromrelativewith a fixed min-height toabsolute top-0 left-0with no background, so it sits on top of the scroll container instead of pushing content downbg-backgroundremoved from the header so it's transparent by defaultbg-backgroundalso removed fromBreadcrumbWithCustomSeparator's wrapper for the same reasonpt-16(non-pdf routes) andpt-12(pdf route) to compensate for the now-overlapping header, so content doesn't start hidden underneath itscroll fade simplified
from-background from-25%to a three-stopfrom-background from-10% via-background/55 via-55% to-transparentwhich gives a softer, more gradual fade and works better over the floating headersticky -top-12 ... -mb-32(a sticky trick to keep it in the flow) toabsolute top-0 left-0which is simpler and doesn't affect scroll layoutrounded-tl-lgadded to match the main content area's corneryoutube embed dialog
pb-2.5 px-4so the dialog content has tighter, more balanced spacingbefore

now

the old header was part of the document flow, which meant the scroll container had to account for its height explicitly and the sticky gradient trick was needed to cover the gap. making the header absolutely positioned simplifies this: the scroll container owns the full height, the header floats above it, and the gradient naturally covers the header area as you scroll.