public note: width toggle, creation date,utils cleanup#764
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
before :

after :

width toggle on the public note page
useNoteWidthhook, so readers get the same narrow/wide layout control that exists in the private editorChevronsLeftRightEllipsiswhen in narrow mode andChevronsRightLeftwhen wide, matching the icon convention used elsewhereMaxWContaineron the public page now applies the same conditional width logic:Desktop:w-[900px] w-full px-4for narrow,px-6for widecreation date in the header
"Created {date}"usingformatNoteTimestampgives readers basic context without cluttering the layoutformatNoteTimestampmoved tolib/utilsNoteSettings.tsx. it's now exported fromlib/utils.tsand imported in bothNoteSettingsand the public note page single source of truth, no duplicationminor button alignment fix
pdf loading skeleton
loading.tsxfor the pdf route now wraps the skeleton inMaxWContainerwithw-[900px]instead of a plaindiv, so the loading state matches the actual pdf viewer dimensionstooltip delay
useHoverTooltipdelay onNoteDownloadDropdownreduced from default to100msto match the rest of the header buttons