pdf toolbar: pagenav polish,PdfSettings variant prop#767
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
before :

now :

page navigator layout
divwithborder-t border-b border-border h-8 bg-backgroundso they form a continuous bordered segment between the prev/next buttons, making the navigator read as a single connected control!border-l-0 !border-t-0 !border-b-0replaced with justborder-border)!rounded-noneso the right edge is square and butts up against thePdfSettingsbutton cleanlyPdfSettingstrigger button now accepts abtnVariantpropbtnVariantprop ("outline" | "SidebarMenuButton" | "SidebarMenuButton_destructive" | "Trigger") so callers can control the button style without overriding classes"Trigger"to preserve existing behavior everywhere the component is already usedbtnVariant="outline"andbtnClassName="h-8 w-8 mt-0 px-1 border-border"so the settings button matches the outline style of the other toolbar buttonsminor
pb-1from the thumbnails "Pg" label that was added in a previous pass it was causing the text to sit slightly low inside the button