Skip to content

pdf toolbar: pagenav polish,PdfSettings variant prop#767

Merged
moehdotdev merged 1 commit into
mainfrom
home-uiux-changes
May 23, 2026
Merged

pdf toolbar: pagenav polish,PdfSettings variant prop#767
moehdotdev merged 1 commit into
mainfrom
home-uiux-changes

Conversation

@moehdotdev

Copy link
Copy Markdown
Member

what changed

before :
image

now :
image

page navigator layout

  • the page input and "of N" label are now wrapped in a shared div with border-t border-b border-border h-8 bg-background so they form a continuous bordered segment between the prev/next buttons, making the navigator read as a single connected control
  • prev button border classes cleaned up (!border-l-0 !border-t-0 !border-b-0 replaced with just border-border)
  • next button gets !rounded-none so the right edge is square and butts up against the PdfSettings button cleanly

PdfSettings trigger button now accepts a btnVariant prop

  • added an optional btnVariant prop ("outline" | "SidebarMenuButton" | "SidebarMenuButton_destructive" | "Trigger") so callers can control the button style without overriding classes
  • defaults to "Trigger" to preserve existing behavior everywhere the component is already used
  • in the viewer toolbar, it's called with btnVariant="outline" and btnClassName="h-8 w-8 mt-0 px-1 border-border" so the settings button matches the outline style of the other toolbar buttons

minor

  • removed pb-1 from the thumbnails "Pg" label that was added in a previous pass it was causing the text to sit slightly low inside the button

@vercel

vercel Bot commented May 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
notevo Building Building Preview, Comment May 23, 2026 11:06pm

@moehdotdev moehdotdev merged commit 5b5020d into main May 23, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant