pdf viewer sidebar-aware rounding and small polish#770
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main changes
before :



now :


pdf viewer adapts to sidebar state
PdfViewerShellandPdfViewerContentnow read{ open, isMobile }fromuseSidebarand applyapp-radius-lgonly when the sidebar is open and not on mobile so the viewer corner rounds when the sidebar is expanded (matching the main content area) and goes flush when it's collapsed or on mobilePdfViewerContentsidebar trigger hidden on pdf routes
SidebarTriggerinHomeClientLayoutis now suppressed on pdf routes (!isPdfRoute) since the pdf viewer renders its own sidebar-aware chrome and the trigger in the global header was overlapping itmove dialogs toast action button
MoveNoteDialogandMovePdfDialogsuccess toast action button padding changed frompx-4topx-3 h-8, and link text getstext-xsinMoveNoteDialogfits better inside the compact toast layouttoast close button
right-1 top-1 p-1toright-0.5 top-0.5 p-0.5so it sits closer to the cornerpr-6topr-7to compensate and prevent content from running under the close button