delete pdfs, storage files when deleting a workspace#776
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
deleteWorkingSpacenow collects all pdfs associated with the workspace before deleting it, covering two cases:by_workingSpaceIdindexby_notesTableIdindexworkingSpaceIdand anotesTableIdpointing to the same workspace)ctx.storage.deleteis called first to remove the actual file from convex storage, thenctx.db.deleteremoves the recordnotesTableIdreferences are still valid during the storage cleanupwhy
before this, deleting a workspace left orphaned pdf records in the db and their files sitting in convex storage indefinitely since there was no owner left to clean them up.