simplify theme toggle to a binary switch#778
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced the 3-option toggle group (light / dark / system) with a single toggle that flips between light and dark. also cleaned up how the toggle is placed in the sidebar dropdown and aligned the feedback button and sign out item styles to match.
before :

now :

what changed:
ToggleGroup+ 3 items for a singleTogglecomponentthemetoresolvedThemeso the ui always reflects the actual active theme, not just the stored preferenceThemeTogglein the sidebar, it now drops in directly as a menu itemThemeToggle,Feedback, and the sign outDropdownMenuItemTriggervariant totoggle.tsxfor the pill stylewhy:
the system theme option wasn't doing much from a ux standpoint and the old layout had extra wrapper divs with a "Theme :" label that felt out of place. this is simpler, more consistent with the rest of the menu items, and the resolved theme fix means the toggle state is always accurate on load.