add inline editable title to the note page#809
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the note title used to only be editable from the sidebar. it's now an inline input at the top of the editor, styled to match the prose heading look.



what changed:
Inputabove the editor inNotePageClientbound toeditedTitlestatedebouncedUpdateNoteTitle(100ms debounce) validates with zod, slugifies the new title, updates the url viarouter.replace, and callsupdateNoteif the title actually changedtext-2xl/md:text-5xl) with all borders, shadows, and rings strippedinput.tsx: removed
shadow-sm, setshadow-noneas default prevents the base shadow showing through on the title inputtoast.tsx: default and destructive variants get a gradient background (
from-card to-muted-foreground/50/to-destructive/50), and destructive close button styles simplified to remove unused group-destructive ring overrides