perf: Optimize debouncer.watch() lookup time#913
Merged
JohnTitor merged 3 commits intonotify-rs:mainfrom May 2, 2026
Merged
Conversation
Use sorted VecDeque on 30k invocations cuts down all the linear scanning work that has be done before. Cuts down 10s to 300ms
dmtrKovalenko
force-pushed
the
fix/per-issues
branch
from
b6bced4 to
c9bbd86
Compare
dmtrKovalenko
commented
Apr 30, 2026
Comment on lines
+593
to
+594
| .roots | ||
| .binary_search_by(|(p, _)| p.as_path().cmp(path.as_path())) |
Contributor
Author
There was a problem hiding this comment.
the path comparison is actually pretty slow in rust as well we could've compared underlying os_str but this will not work with non canonicalized paths
if we do that - performance impact would be absolutely unnoticable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Optimize performance of debouncer.watch() calls
Testing
tested
Description
Use sorted VecDeque on 30k invocations cuts down all the linear scanning work that has be done before. Cuts down 10s to 300ms
Related Issues
closes #912