Route.Request helper for proxied origin (#94) - #100
Draft
nounder wants to merge 1 commit into
Draft
Conversation
Resolves the request origin honoring X-Forwarded-Host/X-Forwarded-Proto so the app reports the public origin when running behind a reverse proxy, falling back to the request URL otherwise. Exposed both as a pure function (Route.requestOrigin) and as Route.Request.origin, an Effect that reads the current request from context. Wires it into CsrfProtection's origin-matching so same-origin checks also work correctly behind a reverse proxy. Closes #94 Co-authored-by: Ralph Gutkowski <nounder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
Summary
Adds a helper to compute the request origin that respects reverse-proxy forwarded headers (
X-Forwarded-Host/X-Forwarded-Proto).Changes
Route.requestOrigin(request)pure helperRoute.Request.originEffect for use inside handlersTest plan
bun test test/Route.test.tsx test/experimental/CsrfProtection.test.ts