Fix slang global session leak in ShaderCooker - #62
Merged
Conversation
SlangBridge's destructor never freed its SlangBridgeData, leaking the slang global session it owns, and ShaderCompiler::Run constructed a new SlangBridge for every shader file - one leaked global session (each holding a compiled slang core module, ~160 MB) per shader. Cooking 65 shaders peaked at ~10.1 GiB RSS and climbed monotonically, OOMing the CI runner. Delete the bridge data in the destructor and construct a single bridge above the shader loop; a global session is designed to be shared for a whole compilation run, and each redundant one was also recompiling the slang core module. Measured on a full 65-shader force recook (Release, 16 threads): peak RSS 10.1 GiB -> 272 MB, wall time 24.0s -> 11.9s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlangBridge's destructor never freed its SlangBridgeData, leaking the slang global session it owns, and ShaderCompiler::Run constructed a new SlangBridge for every shader file - one leaked global session (each holding a compiled slang core module, ~160 MB) per shader. Cooking 65 shaders peaked at ~10.1 GiB RSS and climbed monotonically, OOMing the CI runner.
Delete the bridge data in the destructor and construct a single bridge above the shader loop; a global session is designed to be shared for a whole compilation run, and each redundant one was also recompiling the slang core module.
Measured on a full 65-shader force recook (Release, 16 threads): peak RSS 10.1 GiB -> 272 MB, wall time 24.0s -> 11.9s.