Skip to content

Fix #27 by casting literal strings to varchar in projection lists only#36

Merged
roji merged 1 commit intonpgsql:devfrom
rwasef1830:bug_27_literal_varchar_in_projection_lists_only
Jul 9, 2016
Merged

Fix #27 by casting literal strings to varchar in projection lists only#36
roji merged 1 commit intonpgsql:devfrom
rwasef1830:bug_27_literal_varchar_in_projection_lists_only

Conversation

@rwasef1830
Copy link
Copy Markdown
Contributor

This fixes bug #27 with a tiny behavioral change that would only rarely affect unlikely query scenarios. And in that case a workaround is possible by just using an explicit cast.

@rwasef1830 rwasef1830 changed the title Bug 27 literal varchar in projection lists only Fix #27 by casting literal strings to varchar in projection lists only May 20, 2016
@roji
Copy link
Copy Markdown
Member

roji commented May 26, 2016

@Emill, will you have time to look into this? There's also npgsql/npgsql#1045 which was wrongly closed (branch rename). Hopefully we can finally put this issue to rest at some point...

@rwasef1830
Copy link
Copy Markdown
Contributor Author

I would like to note that the approach in this pull request is far less breaking than the other one.
ie: This pull request is an alternative implementation to npgsql/npgsql#1045

@rwasef1830 rwasef1830 force-pushed the bug_27_literal_varchar_in_projection_lists_only branch from 0925f9c to a2563ae Compare May 31, 2016 16:23
@rwasef1830
Copy link
Copy Markdown
Contributor Author

@roji @Emill Redid the changes based on latest dev. Should be easy to merge now.

Hope this gets pulled soon, tired of maintaining my own fork :-).

@roji
Copy link
Copy Markdown
Member

roji commented May 31, 2016

Sorry this hasn't received much attention, I've been busy with the 3.1 release and other stuff... Promise to dive in soon.

@rwasef1830 rwasef1830 force-pushed the bug_27_literal_varchar_in_projection_lists_only branch from a2563ae to a2c7229 Compare June 8, 2016 12:26
@rwasef1830
Copy link
Copy Markdown
Contributor Author

Squashed to a single commit for easy fast-forward merge and review ;-)

@roji
Copy link
Copy Markdown
Member

roji commented Jul 7, 2016

@rwasef1830, just to let you know I haven't forgotten about this (even though it's been a month). I'm really taken up with other things but promise to find some time soon...

@rwasef1830 rwasef1830 force-pushed the bug_27_literal_varchar_in_projection_lists_only branch from a2c7229 to a0d32ac Compare July 8, 2016 14:01
@rwasef1830 rwasef1830 force-pushed the bug_27_literal_varchar_in_projection_lists_only branch from a0d32ac to e1689b9 Compare July 8, 2016 14:04
@rwasef1830
Copy link
Copy Markdown
Contributor Author

rwasef1830 commented Jul 8, 2016

Updated to fix conflicts and be ready for review and merge (wink) in next fix release.

@roji roji merged commit c203687 into npgsql:dev Jul 9, 2016
@rwasef1830 rwasef1830 deleted the bug_27_literal_varchar_in_projection_lists_only branch July 9, 2016 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants