Fix arrays over JsonDocument/JsonElement#3747
Merged
roji merged 1 commit intonpgsql:mainfrom Feb 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression introduced in version 10.0.0 where mapping arrays of JsonDocument or JsonElement to PostgreSQL jsonb[] columns would fail with an InvalidOperationException. The root cause was that NpgsqlJsonTypeMapping was unconditionally using JsonStringReaderWriter.Instance for all CLR types, but this reader/writer is specifically designed for string types and causes validation failures when used with JSON types like JsonDocument and JsonElement.
Changes:
- Fixed
NpgsqlJsonTypeMappingto only useJsonStringReaderWriter.Instanceforstringtype, passingnullfor other types to allow EF Core to determine the appropriate reader/writer - Fixed error message formatting in
NpgsqlArrayTypeMappingto correctly display type names - Added comprehensive test coverage for arrays and lists of
JsonDocumentandJsonElement
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/EFCore.PG/Storage/Internal/Mapping/NpgsqlJsonTypeMapping.cs |
Fixed constructor to conditionally assign JsonStringReaderWriter only for string types |
src/EFCore.PG/Storage/Internal/Mapping/NpgsqlArrayTypeMapping.cs |
Fixed error message formatting bug (removed incorrect .GetType() call on Type object) |
test/EFCore.PG.Tests/Storage/NpgsqlTypeMappingSourceTest.cs |
Added test coverage for JsonDocument/JsonElement arrays and lists; added System.Text.Json import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roji
added a commit
that referenced
this pull request
Feb 22, 2026
Member
Author
|
Backported to 10.0.1 via 7bae265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3677