Commented out semicolon NOT ignored

[bertl]

If there is a semicolon within a single line comment "--", Npgsql
assumes that it marks the end of a statement and starts the next
statement (chunk) immediately after it, ignoring that this is still
commented out.
This commit ignores semicolons within single line comments.

I have created a test demonstrating the issue:
This will throw an exception although the command is valid (though meaningless in this case)

[Test]
public void CommentedOutSemicolon()
{
  var command = new NpgsqlCommand("-- 1\n-- 2; abc\n-- 3;", Conn);
  command.ExecuteNonQuery();
}

[glenebob]

Hi @bertl,

I added your test, and a couple others, to the project.

I then fixed the query re-writer to handle comments properly. So far, these changes are only in master.

Please, if you would, grab the latest sources and see if my changes work for you. I expect this will be merged in 2.1 soon.

Thanks!

-Glen

[bertl]

Hi @glenebob,

thanks for fixing this! Your change looks good and seems to work fine. Nice that you are now also "cutting" out block comments.

Cheers!

[glenebob]

Fixed in master and 2.1.