chore: refactor fund tests to test/lib#1582
Closed
ruyadorno wants to merge 1 commit intonpm:release/v7.0.0-betafrom
Closed
chore: refactor fund tests to test/lib#1582ruyadorno wants to merge 1 commit intonpm:release/v7.0.0-betafrom
ruyadorno wants to merge 1 commit intonpm:release/v7.0.0-betafrom
Conversation
ruyadorno
added
Enhancement
isaacs
reviewed
Jul 31, 2020
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
One eyebrow-raise (might just be a confusing test name?) and a suggestion to tighten up code in one spot to replace a let with a const. LGTM otherwise, and if those comments aren't valid, feel free to ignore them :)
ruyadorno
force-pushed
the
refactor-fund-tests
branch
from
25a6adb to
28a63f9
Compare
Contributor
Author
|
should be good to go now ✅ |
Refactored `npm fund` tests to use new `test/lib/` unit tests structure. ref: npm/statusboard#151
ruyadorno
force-pushed
the
refactor-fund-tests
branch
from
28a63f9 to
9d49b15
Compare
Closed
isaacs
pushed a commit
that referenced
this pull request
Aug 4, 2020
Refactored `npm fund` tests to use new `test/lib/` unit tests structure. ref: npm/statusboard#151 PR-URL: #1582 Credit: @ruyadorno Close: #1582 Reviewed-by: @isaacs
Contributor
|
Landed on 68a16d6, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
npm fundtests to use newtest/lib/unit tests structure.ref: npm/statusboard#151