Closed
Conversation
Refactored `npm fund` tests to use new `test/lib/` unit tests structure. ref: npm/statusboard#151
ruyadorno
added
Enhancement
Contributor
|
Are you ok with throwing a |
isaacs
pushed a commit
that referenced
this pull request
Aug 4, 2020
PR-URL: #1593 Credit: @ruyadorno Close: #1593 Reviewed-by: @isaacs EDIT(@isaacs): Added black background to the highlighted text so that it won't disappear on light terminal settings.
Contributor
|
Landed on 4906ee5, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colors were always missing from fund, since they were somewhat messed up on
npm lsit never bothered me that much but now that they're fixed there it hurts my eye to see the raw output fromnpm fund- I'm adding at least the defaultchalkcolor so that it looks better with terminal color schemes.Before
After
npm ls (for ref)