docs: clarify npm 12 unknown-config breaking change in changelogs#9805
Open
Hashim1999164 wants to merge 1 commit into
Open
docs: clarify npm 12 unknown-config breaking change in changelogs#9805Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
The stable 12.0.0 / config 11.0.0 breaking-change notes still said unknown .npmrc keys throw. That was reverted before the stable cut (npm#9729): file configs warn by default again, with strict-npmrc to opt into errors, while unknown CLI flags and abbreviations still throw. Align the published changelog bullets with the corrected pre.1 wording from npm#9733 so release notes match actual npm 12 behavior. Fixes npm#9802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9802.
Before the npm 12 stable cut, #9729 restored warn-by-default for unknown
.npmrckeys (withstrict-npmrcto opt into errors). #9733 updated the12.0.0-pre.1changelog bullet to match, but the aggregated stable12.0.0/@npmcli/config@11.0.0breaking-change notes (and the config package'spre.1note) still said unknown.npmrcconfigs throw.That stale line also shipped in the published v12.0.0 GitHub release notes.
This aligns those changelog bullets with the corrected wording:
Maintainers may also want to refresh the published
v12.0.0release body to match; that cannot be updated via this PR alone.References
.npmrcconfigs)pre.1changelog note)