fix(arborist): honor gypfile:false on lockfile-driven installs - #9859
Open
lazerg wants to merge 1 commit into
Open
fix(arborist): honor gypfile:false on lockfile-driven installs#9859lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gypfile: falseopts a package out of thenode-gyp rebuildinstall script npm synthesises when it finds abinding.gyp. That opt-out only survives when the tree node was built from a packument or read off disk. Nodes built from a lockfile carry nogypfilefield at all, so onnpm ci, or on anynpm installwith an existingpackage-lock.json, npm sees thebinding.gypand adds the script anyway.With
better-sqlite3@13.0.2that shows up as a spuriousinstall-scriptswarning. It is not only cosmetic: the synthesised script is real, so once it is covered byallowScripts(or on npm 10, which has no such gate)node-gyp rebuildactually runs against a package that ships prebuilt binaries and asked not to be rebuilt.Both the script enumeration in
install-scripts.jsand the build set inrebuild.jsnow read the opt-out back from the installedpackage.jsonwhen the node itself does not know it.Fixes #9837
Testing
Against the repro in the issue,
npm cino longer warns, andnpm ci --dangerously-allow-all-scripts --foreground-scriptsno longer invokes node-gyp. Added regression tests for both paths.