Skip to content

chore: resolve broken alert rendering in nested list#1065

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
RYGRIT:chore/fix-alert-indentation
Feb 6, 2026
Merged

chore: resolve broken alert rendering in nested list#1065
danielroe merged 2 commits intonpmx-dev:mainfrom
RYGRIT:chore/fix-alert-indentation

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Feb 6, 2026

Fixed a small rendering issue here. GitHub alerts (like [!IMPORTANT]) don't render correctly when indented inside lists. I switched it to standard bold text (Important:) .

image

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 10:02am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 10:02am
npmx-lunaria Ignored Ignored Feb 6, 2026 10:02am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request updates CONTRIBUTING.md in the "Adding a new locale" section. The [!IMPORTANT] block quote marker was replaced with a ⚠ emoji and bold text formatted as **Important:**. No functional or behavioural changes were made to the documentation.

Suggested reviewers

  • danielroe
  • trueberryless
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the rendering issue with GitHub alerts in indented lists and describes the solution applied.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

CONTRIBUTING.md Outdated
```

> [!IMPORTANT]
> **Important:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help to be even more visible to add an icon in front of it like ⚠️ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -337 to 338
> [!IMPORTANT]
> ⚠**Important:**
> This file must be committed. Lunaria uses git history to track translation progress, so the build will fail if this file is missing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be an option to just move it to the top level here.

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit 1ba5200 Feb 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants