chore: use vueuse useEventListener for correct cleanups
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrbisK is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
43081j
approved these changes
Jan 26, 2026
Collaborator
43081j
left a comment
43081j
left a comment
There was a problem hiding this comment.
makes sense to me, vueuse already has the utils so we may as well lean on them imo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/code/[...path].vuewas missing its cleanup. I replaced all.addEventListenerwith vueuseuseEventListener