Skip to content

fix(a11y): include latest hash and params for skip button#1443

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
OrbisK:fix/a11y-skip-button-hash
Feb 12, 2026
Merged

fix(a11y): include latest hash and params for skip button#1443
danielroe merged 1 commit intonpmx-dev:mainfrom
OrbisK:fix/a11y-skip-button-hash

Conversation

@OrbisK
Copy link
Contributor

@OrbisK OrbisK commented Feb 12, 2026

fixes #1437

ensures that we keep the query and params on skip link.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 8:03pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 8:03pm
npmx-lunaria Ignored Ignored Feb 12, 2026 8:03pm

Request Review

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/app.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

This change modifies the skip link in app/app.vue to navigate using a dynamic router object instead of a static route string. The :to binding now includes the hash '#main-content' along with the current route's query parameters and route params, preserving the existing route context during navigation. This addresses the issue where activating the skip link was previously clearing query parameters from the URL.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly addresses the linked issue #1437, describing the fix to preserve query and params on the skip link.
Linked Issues check ✅ Passed The changes implement the required fix for issue #1437 by modifying the skip link to preserve query parameters and route parameters when navigating.
Out of Scope Changes check ✅ Passed All changes in app.vue are directly related to fixing the skip link functionality and do not introduce unrelated modifications.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@OrbisK
Copy link
Contributor Author

OrbisK commented Feb 12, 2026

Copy link
Member

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it works!

@ben-basten
Copy link

Thank you for the quick response to the issue! I just tried the deployment preview - it looks like this PR fixes the query param issue, but now focus no longer moves to the main content and stays on the skip link. So the actual "skip" never happens.

@danielroe danielroe added this pull request to the merge queue Feb 12, 2026
@danielroe
Copy link
Member

merging as a hotfix but I think this is an issue with LinkBase

Merged via the queue into npmx-dev:main with commit e6f9eef Feb 12, 2026
17 checks passed
@alexdln
Copy link
Member

alexdln commented Feb 12, 2026

It seems that "NuxtLink" and HTML "a" behave differently in the context of hash anchors...

@OrbisK
Copy link
Contributor Author

OrbisK commented Feb 13, 2026

@ben-basten Thank you! I have fixed this in #1460

@ben-basten
Copy link

@OrbisK That looks great, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip link clears query params

5 participants