fix(a11y): include latest hash and params for skip button#1443
fix(a11y): include latest hash and params for skip button#1443danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis change modifies the skip link in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
|
|
Thank you for the quick response to the issue! I just tried the deployment preview - it looks like this PR fixes the query param issue, but now focus no longer moves to the main content and stays on the skip link. So the actual "skip" never happens. |
|
merging as a hotfix but I think this is an issue with LinkBase |
|
It seems that "NuxtLink" and HTML "a" behave differently in the context of hash anchors... |
|
@ben-basten Thank you! I have fixed this in #1460 |
|
@OrbisK That looks great, thank you!! |
fixes #1437
ensures that we keep the query and params on skip link.