fix(i18n): missing number formatting#2158
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated number localisation and formatting in three files. In app/components/Package/TableRow.vue the component-local Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the high-level summary generated by CodeRabbit.Configure the |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/pages/search.vue (1)
604-611:⚠️ Potential issue | 🟡 MinorInconsistent formatting in live region message.
The screen reader live region at lines 604–611 still uses
pSize.toString()for thepageSizeparameter, while line 812 now uses$n(). For consistency and correct localisation in assistive technologies, this should also use$n().🔧 Proposed fix
return $t( 'filters.count.showing_paginated', { - pageSize: pSize.toString(), + pageSize: $n(pSize), count: $n(effectiveTotal.value), }, effectiveTotal.value, )
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d4531756-e379-4162-b665-994eb452e3ca
📒 Files selected for processing (3)
app/components/Package/TableRow.vueapp/components/PaginationControls.vueapp/pages/search.vue
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
🔗 Linked issue
🧭 Context
Was testing the site in different languages, and noticed that some numbers are not locale formatted
Unformatted numbers found in: packages table view, pagination
📚 Description
Updated components to use the
$nfunction for formatting numbers, as well as previously built compact numbers formatter