Skip to content

fix(i18n): missing number formatting #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Mar 20, 2026
Merged

fix(i18n): missing number formatting #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e5ed4
fix(i18n): missing number formatting
DDeenis Mar 19, 2026
848aedf
fix: do a proper null check
DDeenis Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/components/Package/TableRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ const isSelected = computed<boolean>(() => {
return isPackageSelected(props.result.package.name)
})
function formatDownloads(count?: number): string {
if (count === undefined) return '-'
if (count >= 1_000_000) return `${(count / 1_000_000).toFixed(1)}M`
if (count >= 1_000) return `${(count / 1_000).toFixed(1)}K`
return count.toString()
}
function formatScore(value?: number): string {
if (value === undefined || value === 0) return '-'
return Math.round(value * 100).toString()
Expand All @@ -44,6 +37,8 @@ const allMaintainersText = computed(() => {
if (!pkg.value.maintainers?.length) return ''
return pkg.value.maintainers.map(m => m.name || m.email).join(', ')
})
const compactNumberFormatter = useCompactNumberFormatter()
</script>

<template>
Expand Down Expand Up @@ -89,7 +84,11 @@ const allMaintainersText = computed(() => {
v-if="isColumnVisible('downloads')"
class="py-2 px-3 font-mono text-xs text-fg-muted text-end tabular-nums"
>
{{ formatDownloads(result.downloads?.weekly) }}
{{
result.downloads?.weekly !== undefined
? compactNumberFormatter.format(result.downloads.weekly)
: '-'
}}
</td>

<!-- Updated -->
Expand Down
4 changes: 2 additions & 2 deletions app/components/PaginationControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ function handlePageSizeChange(event: Event) {
@change="handlePageSizeChange"
:items="
PAGE_SIZE_OPTIONS.map(size => ({
label: $t('filters.pagination.per_page', { count: size }),
label: $t('filters.pagination.per_page', { count: $n(size) }),
value: String(size),
}))
"
Expand Down Expand Up @@ -207,7 +207,7 @@ function handlePageSizeChange(event: Event) {
:aria-current="page === currentPage ? 'page' : undefined"
@click="goToPage(page)"
>
{{ page }}
{{ $n(page) }}
</button>
</template>

Expand Down
2 changes: 1 addition & 1 deletion app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ onBeforeUnmount(() => {
$t(
'filters.count.showing_paginated',
{
pageSize: Math.min(preferredPageSize, effectiveTotal),
pageSize: $n(Math.min(preferredPageSize, effectiveTotal)),
count: $n(effectiveTotal),
},
effectiveTotal,
Expand Down
Loading