Skip to content

chore: revert "docs(ui): add dark theme for storybook docs (#2062)"#2167

Merged
ghostdevv merged 1 commit intomainfrom
revert-storybook-theme
Mar 20, 2026
Merged

chore: revert "docs(ui): add dark theme for storybook docs (#2062)"#2167
ghostdevv merged 1 commit intomainfrom
revert-storybook-theme

Conversation

@ghostdevv
Copy link
Contributor

@ghostdevv ghostdevv commented Mar 20, 2026

Merging #2062 seems to have broken the Storybook/Chromatic CI so this reverts it so we have time to figure that out

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 20, 2026 8:40am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Mar 20, 2026 8:40am
npmx-lunaria Ignored Ignored Mar 20, 2026 8:40am

Request Review

@ghostdevv ghostdevv changed the title Revert "docs(ui): add dark theme for storybook docs (#2062)" chore: revert "docs(ui): add dark theme for storybook docs (#2062)" Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv marked this pull request as ready for review March 20, 2026 08:41
@ghostdevv ghostdevv enabled auto-merge March 20, 2026 08:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

The pull request modifies Storybook configuration files to simplify the setup. The stories glob pattern in main.ts is updated to load only Vue/JS/TS story files from the ../app/**/*.stories.@(js|ts) directory, removing the pattern for MDX files in .storybook/*.mdx. The theme module is removed entirely, and theme configuration references are deleted from preview.ts. The manager.ts file is updated to replace the imported theme with an inline theme object whilst removing toolbar-hiding logic. Additionally, the welcome MDX page and custom background styling for the docs story canvas are removed.

Possibly related PRs

Suggested reviewers

  • cylewaitforit
  • alexdln
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains that it reverts a previous change that broke Storybook/Chromatic CI, which directly relates to the changeset removing theme and configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-storybook-theme
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6a1cfca-28a6-4c9b-a86e-d498323e48dc

📥 Commits

Reviewing files that changed from the base of the PR and between f0ada7e and c871aac.

📒 Files selected for processing (6)
  • .storybook/main.ts
  • .storybook/manager.ts
  • .storybook/preview-head.html
  • .storybook/preview.ts
  • .storybook/storybook-welcome.mdx
  • .storybook/theme.ts
💤 Files with no reviewable changes (4)
  • .storybook/preview-head.html
  • .storybook/storybook-welcome.mdx
  • .storybook/theme.ts
  • .storybook/preview.ts

@RYGRIT
Copy link
Contributor

RYGRIT commented Mar 20, 2026

Could this be the reason why the Chromatic CI is failing? I just submitted a PR, and the Chromatic CI failed; I'm not sure exactly what happened.😳

@ghostdevv
Copy link
Contributor Author

Could this be the reason why the Chromatic CI is failing? I just submitted a PR, and the Chromatic CI failed; I'm not sure exactly what happened.😳

It is yea

@ghostdevv ghostdevv added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 9ae5629 Mar 20, 2026
24 of 26 checks passed
@ghostdevv ghostdevv deleted the revert-storybook-theme branch March 20, 2026 08:54
@github-actions
Copy link

Thanks for your first contribution, @ghostdevv! ⭐

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants