feat: welcome first contributors when PR opens#2236
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRenames the workflow display name in Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ghostdevv
left a comment
There was a problem hiding this comment.
Maybe we could do both messages? The opentelling them to ask any questions they might have and/or join the discord and then the close message telling them congratulations and you can go to here to get a contributor role
…d contribution workflow
Awesome idea, so many welcomes, I'm almost overwhelmed. |
|
I also adapted the new action to use a fork of the first-interaction action, because the original is not as performant (because it's not using the |
ghostdevv
left a comment
There was a problem hiding this comment.
I think they could be part of the same .yml file and then we could use the if on the job to detect the event? Not 100% though
I don't like putting them in one action because it adds a lot of unnecessary overhead that can cleanly be avoided because we have two different GitHub events ( |
I lean towards one just to reduce the file count in the workflows dir - I thought that if we're using the |
I wouldn't consider myself an expert in how GitHub Actions optimize such conditional steps or jobs. I was just thinking about the maintenance of one bigger workflow vs two smaller ones. But I guess more files in the workflow folder also doesn't make maintenance easier, so I would be okay to combine the two (it's just more prune to errors as always with GitHub Actions, let the trail and error begin 😅) |
Yeaaa GitHub actions is ✨ fun ✨ - oki let's just leave it as two and if we need to we can merge them together later |
where'd you find the fork? could we just use actions script like the close one? |
|
We have been using the fork action for quite some time now in Starlight (ref) and it runs flawlessly (apart from yesterdays changes, where I tried to use the official action, but it's too restrictive). I advise to use the fork one instead of a new script as it already works. You can also read many benefits of in this PR from HiDeoo. |
ah sweet, let's do it |
😂😂😂 I just can't anymore 🤣🤣🤣 |
this is why they invented squash merging 😌 😂 |
🧭 Context
I noticed we already have a welcoming messages for new contributors, however this message is not sent until the PR is merged. This way, maintainers are unknowingly during PR review that this is the first PR of the person. Therefore, I created a second action which writes and immediate message to the PR as soon as it gets opened.
📚 Description
This PR adds a new workflow which uses https://github.com/zephyrproject-rtos/action-first-interaction as this fork is more performant and flexible (see example issue) than the official action. It gives the new contributor confidence and tells them what all those bot messages mean, so they are not overwhelmed.