Skip to content

fix: add missing token to first-time contributor welcome workflow#2264

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
MathurAditya724:patch-6
Mar 24, 2026
Merged

fix: add missing token to first-time contributor welcome workflow#2264
ghostdevv merged 1 commit intonpmx-dev:mainfrom
MathurAditya724:patch-6

Conversation

@MathurAditya724
Copy link
Contributor

@MathurAditya724 MathurAditya724 commented Mar 24, 2026

🔗 Linked issue

N/A — discovered from a failing CI job on #2262

🧭 Context

The "Greet First-Time Contributors" workflow (added in #2236) fails on every new contributor's PR because a required action input is missing.

📚 Description

The zephyrproject-rtos/action-first-interaction action requires a repo-token input to authenticate with the GitHub API, but it wasn't being supplied. This adds repo-token: ${{ secrets.GITHUB_TOKEN }} to the workflow. The workflow already has permissions: pull-requests: write so no additional permission changes are needed.

Failing job: https://github.com/npmx-dev/npmx.dev/actions/runs/23489827599/job/68354800411?pr=2262

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 24, 2026 2:48pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Mar 24, 2026 2:48pm
npmx-lunaria Ignored Ignored Mar 24, 2026 2:48pm

Request Review

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@MathurAditya724 MathurAditya724 changed the title fix(ci): add missing repo-token to first-time contributor greeting workflow fix: add missing repo-token to first-time contributor greeting workflow Mar 24, 2026
@ghostdevv ghostdevv self-requested a review March 24, 2026 15:22
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks, I missed that in #2236

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still broken but maybe merging will help 🤔

@ghostdevv ghostdevv changed the title fix: add missing repo-token to first-time contributor greeting workflow fix: add missing repo-token to first-time contributor welcome workflow Mar 24, 2026
@ghostdevv ghostdevv changed the title fix: add missing repo-token to first-time contributor welcome workflow fix: add missing token to first-time contributor welcome workflow Mar 24, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Mar 24, 2026
Merged via the queue into npmx-dev:main with commit 6ead0a8 Mar 24, 2026
22 of 25 checks passed
@trueberryless
Copy link
Contributor

It's still broken but maybe merging will help 🤔

Yes, that's expected because the trigger is pull_request_target which will read the main branch, and since it was not merged when the PR is created, it reads the old action. 👍

@ghostdevv
Copy link
Contributor

It's still broken but maybe merging will help 🤔

Yes, that's expected because the trigger is pull_request_target which will read the main branch, and since it was not merged when the PR is created, it reads the old action. 👍

ahhh TIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants