Skip to content

feat: add nodejs noodle#2778

Merged
alexdln merged 9 commits into
npmx-dev:mainfrom
alexdln:feat/noodle-nodejs
May 25, 2026
Merged

feat: add nodejs noodle#2778
alexdln merged 9 commits into
npmx-dev:mainfrom
alexdln:feat/noodle-nodejs

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented May 21, 2026

🧭 Context

New noodle 🍜

image

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 25, 2026 1:20pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview May 25, 2026 1:20pm
npmx-lunaria Ignored Ignored May 25, 2026 1:20pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Replaces the Press noodle with a Node.js noodle: adds Nodejs/Logo.vue (tooltip + SVG), updates ACTIVE_NOODLES to use the Node.js logo for 2026-05-27, updates a11y tests to mount the Node.js logo, adds a knip ignore, and exposes tooltipAttr in Tooltip/App.

Changes

Noodle logo replacement

Layer / File(s) Summary
Node.js logo component
app/components/Noodle/Nodejs/Logo.vue
Adds a Vue SFC that renders a TooltipApp with a Node.js release note and a code-styled message, and includes the Node.js SVG logo with localized :alt text and responsive sizing classes.
Noodle registry import and active entry
app/components/Noodle/index.ts
Swaps import from the Press logo to the Node.js logo and updates ACTIVE_NOODLES to activate the Node.js noodle with key, logo reference, and date 2026-05-27.
Accessibility tests and tooling ignore
test/nuxt/a11y.spec.ts, knip.ts
Replaces NoodlePressLogo with NoodleNodejsLogo in the a11y audit import and mounts the Node.js logo for the axe check; adds app/components/ColorScheme/Img.vue to knip's root workspace ignoreFiles.
Tooltip prop and attrs wiring
app/components/Tooltip/App.vue
Adds optional tooltipAttr prop and merges it into the computed tooltipAttrs to allow passing arbitrary attributes onto the tooltip element.

Possibly related PRs

  • npmx-dev/npmx.dev#2666: Modifies the noodles registry and a11y tests; that PR introduced/used the Press logo while this PR replaces it with the Node.js logo.

Suggested reviewers

  • graphieros
  • patak-cat
  • serhalp
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add nodejs noodle' directly summarizes the main change: introducing a new Node.js noodle component to the application.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description relates to the changeset, introducing a new Node.js noodle component with a visual screenshot showing the updated interface.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/components/Noodle/Nodejs/Logo.vue 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/Noodle/Nodejs/Logo.vue`:
- Around line 9-12: The external anchor element in Logo.vue that sets
target="_blank" for the Node.js release link (the <a ...
href="https://github.com/nodejs/node-v0.x-archive/releases/tag/v0.0.1"
target="_blank"> anchor) should include rel="noopener noreferrer" to prevent
reverse-tabnabbing; update that anchor element to add rel="noopener noreferrer"
alongside the existing attributes (keeping class="underline" and href intact).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 085ae28a-6d74-4507-ab71-880d1ce386fe

📥 Commits

Reviewing files that changed from the base of the PR and between f2be533 and 020cde6.

📒 Files selected for processing (4)
  • app/components/Noodle/Nodejs/Logo.vue
  • app/components/Noodle/Press/Logo.vue
  • app/components/Noodle/index.ts
  • test/nuxt/a11y.spec.ts
💤 Files with no reviewable changes (1)
  • app/components/Noodle/Press/Logo.vue

Comment thread app/components/Noodle/Nodejs/Logo.vue
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/Tooltip/App.vue`:
- Line 43: Currently attrs is built by spreading consumer props.tooltipAttr
after setting role and id, allowing consumers to override component-owned
accessibility attributes (role and id) and break aria-describedby linkage;
change construction so component-owned attributes (role: 'tooltip' and id:
tooltipId) are applied last or otherwise take precedence over props.tooltipAttr
(e.g., merge as {...props.tooltipAttr, role: 'tooltip', id: tooltipId} or assign
role/id after spreading) so that attrs, tooltipId, and role remain authoritative
and cannot be overridden by props.tooltipAttr.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b55f916c-ad4c-4b67-a8a9-f14a3a593804

📥 Commits

Reviewing files that changed from the base of the PR and between 666fd4a and 895753d.

📒 Files selected for processing (2)
  • app/components/Noodle/Nodejs/Logo.vue
  • app/components/Tooltip/App.vue

Comment thread app/components/Tooltip/App.vue
Comment thread app/components/Tooltip/App.vue
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/Noodle/index.ts`:
- Around line 33-34: The noodle currently sets both date and dateTo to
'2026-05-27', which makes the active-range check in Landing/IntroHeader.vue only
pass at midnight; for a single-day noodle remove the dateTo property and leave
only date so the timezone-aware same-day branch is used. Edit the Noodle export
(the object containing date and dateTo in app/components/Noodle/index.ts) to
omit the dateTo field for this entry (keep date: '2026-05-27') so the
component's single-day logic is triggered.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f1ed4b5-ed62-4e81-bcba-be2e72e29008

📥 Commits

Reviewing files that changed from the base of the PR and between 394e6f6 and da0ed8c.

📒 Files selected for processing (1)
  • app/components/Noodle/index.ts

Comment thread app/components/Noodle/index.ts Outdated
@alexdln alexdln added this pull request to the merge queue May 25, 2026
Merged via the queue into npmx-dev:main with commit 8879a03 May 25, 2026
24 checks passed
@alexdln alexdln deleted the feat/noodle-nodejs branch May 25, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants