Skip to content

fix(i18n): update Japanese translations#2825

Merged
ghostdevv merged 2 commits into
mainfrom
shuuji3/fix/update-japanese
May 31, 2026
Merged

fix(i18n): update Japanese translations#2825
ghostdevv merged 2 commits into
mainfrom
shuuji3/fix/update-japanese

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented May 31, 2026

🔗 Linked issue

N/A

📚 Description

Updated the Japanese translations just for four new strings.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 31, 2026 4:19pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored May 31, 2026 4:19pm
npmx-lunaria Ignored Ignored May 31, 2026 4:19pm

Request Review

@shuuji3 shuuji3 changed the title fix(i18n): fill missing keys fix(i18n): update Japanese translations May 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 71d22c88-9191-40af-8403-abcbc36b87b0

📥 Commits

Reviewing files that changed from the base of the PR and between 0a36394 and c0b5f10.

📒 Files selected for processing (1)
  • i18n/locales/ja-JP.json

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Expanded Japanese language support with new translations for the downloads section, including version-distribution metrics and weekly download statistics labels.
    • Added Japanese translations for team-related information and role designations in the about section.

Walkthrough

This PR extends Japanese locale translations in i18n/locales/ja-JP.json by adding four new keys: a version distribution weekly downloads title and three team section labels (core, maintainers, and role_core) for describing team member roles on the about page.

Changes

Japanese Locale Translations

Layer / File(s) Summary
Locale translation keys for version distribution and team sections
i18n/locales/ja-JP.json
Adds version_distribution_title for weekly download statistics display and three team-related keys (core, maintainers, role_core) for team member role descriptions on the about page.

Possibly related PRs

  • npmx-dev/npmx.dev#2757: Updates Spanish locale with new translation keys across various UI sections, following the same pattern of expanding i18n locale coverage.

Suggested reviewers

  • graphieros
  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the changeset as an update to Japanese translations, which matches the actual changes to the i18n/locales/ja-JP.json file.
Description check ✅ Passed The description is directly related to the changeset, clearly stating that Japanese translations were updated for four new strings, which aligns with the file changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shuuji3/fix/update-japanese

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ja-JP.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue May 31, 2026
Merged via the queue into main with commit 719cb3d May 31, 2026
29 checks passed
@ghostdevv ghostdevv deleted the shuuji3/fix/update-japanese branch May 31, 2026 16:31
@github-actions github-actions Bot mentioned this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants