feat(ui): support takumi v2 og images#2986
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe changes update OG image rendering, change OgLayout's root class, bump takumi and nuxt-og-image dependencies, and refactor the e2e snapshot test suite with new registry, downloads, and jsDelivr fixtures. ChangesOG image rendering, fixtures, and dependency updates
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
07aa320 to
5aa2e46
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
5aa2e46 to
a601475
Compare
|
fwiw i deduped the oxc-parser version, which saves about ~8mb (~72 deps) as latest og image introduced a new version |
| '@types/node': 24.12.0 | ||
| nuxt-og-image: ^6.6.0 | ||
| nuxt-og-image: ^6.7.2 | ||
| oxc-parser: 0.138.0 |
There was a problem hiding this comment.
oxc-parser: 0.138.0
I worry we'll forget about this and it'll break things, or it'll just break things
There was a problem hiding this comment.
i can revert it, it will just cause an extra ~8mb (~72 deps), we need oxc-parser to release a stable so the minors can be deduped
The transforms are build-time, so errors should surface via the build, bumping this is a maintenance concern, though, so I'd leave it for you to decide
# Conflicts: # pnpm-lock.yaml
🔗 Linked issue
N/A
🧭 Context
While checking out the live site a few OG image routes were visibly broken. The regressions showed up as shifted absolute overlays, black repo icons, and unstable package compare output.
https://npmx.dev/package-code/takumi-js/v/1.8.7
📚 Description
While fixing this I figured we just upgrade to latest og image / takumi versions.
nuxt-og-imageto6.7.2and Takumi packages to2.0.0-rc.5.takumi-jsnested tree case and the compare-package snapshot, then refreshes the affected OG snapshots.