Skip to content

feat: add "create new account" button to PDS page#3022

Merged
ghostdevv merged 4 commits into
npmx-dev:mainfrom
ascorbic:pds-create-account
Jul 22, 2026
Merged

feat: add "create new account" button to PDS page#3022
ghostdevv merged 4 commits into
npmx-dev:mainfrom
ascorbic:pds-create-account

Conversation

@ascorbic

@ascorbic ascorbic commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#3021

🧭 Context

The current /pds page only has a link to PDS MOOver, with no way to directly create a new account. To create a new account (rather than migrating) a user needs to open the "Connect" menu, select "Connect to Atmosphere", then click the button in the modal.

📚 Description

This PR adds a button alongside the PDS Moover one that calls authRedirect in the same way as the equivalent in the modal.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 22, 2026 11:12am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 22, 2026 11:12am
npmx-lunaria Ignored Ignored Jul 22, 2026 11:12am

Request Review

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @ascorbic! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f4c7c1ef-aa2a-4c74-991d-ba65fd8b14fd

📥 Commits

Reviewing files that changed from the base of the PR and between 6f60bdc and 07ce4a8.

📒 Files selected for processing (1)
  • app/pages/pds.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/pages/pds.vue

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a prominent “Create account” button to the join section.
    • Account creation now redirects users through authentication and returns them to their current page and language.
    • Updated the join section layout to accommodate the new action.

Walkthrough

Changes

The PDS page now provides a create-account button that redirects through authRedirect to npmx.social, preserving the current route and locale after authentication.

PDS create account flow

Layer / File(s) Summary
Create account handler and button wiring
app/pages/pds.vue
Adds handleCreateAccount and a primary button in the join section using the translated create-account label.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant PdsPage
  participant AuthRedirect
  participant NpmxSocial

  User->>PdsPage: Click create-account button
  PdsPage->>AuthRedirect: Start account creation with route and locale
  AuthRedirect->>NpmxSocial: Redirect to npmx.social
  NpmxSocial-->>PdsPage: Return to current route
Loading

Possibly related issues

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding a create account button to the PDS page.
Description check ✅ Passed The description is directly related to the change and explains the new account-creation button on /pds.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv linked an issue Jul 22, 2026 that may be closed by this pull request
3 tasks

@ghostdevv ghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! I switched the new translation string out for the one that we use on the "Connect to Atmosphere" modal as they're identical - we can split them again later if it makes sense 🙏

@ghostdevv
ghostdevv enabled auto-merge July 22, 2026 11:10
@ghostdevv
ghostdevv added this pull request to the merge queue Jul 22, 2026
Merged via the queue into npmx-dev:main with commit b9fa082 Jul 22, 2026
23 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @ascorbic! 🎊

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@ThisIsMissEm

Copy link
Copy Markdown

Keep in mind that prompt of create isn't part of the OAuth spec yet for at protocol, so it'll probably only work with the reference implementation (you can discover this via the AS metadata)

@ghostdevv

Copy link
Copy Markdown
Member

Keep in mind that prompt of create isn't part of the OAuth spec yet for at protocol, so it'll probably only work with the reference implementation (you can discover this via the AS metadata)

good to know! if we switch out the underlying PDS impl in the future we can always change the logic to match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDS page should have a "Create new account" button

3 participants