feat: add "create new account" button to PDS page#3022
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @ascorbic! 🚀 Here’s what will happen next:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe PDS page now provides a create-account button that redirects through PDS create account flow
Sequence Diagram(s)sequenceDiagram
participant User
participant PdsPage
participant AuthRedirect
participant NpmxSocial
User->>PdsPage: Click create-account button
PdsPage->>AuthRedirect: Start account creation with route and locale
AuthRedirect->>NpmxSocial: Redirect to npmx.social
NpmxSocial-->>PdsPage: Return to current route
Possibly related issues
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ghostdevv
left a comment
There was a problem hiding this comment.
ty! I switched the new translation string out for the one that we use on the "Connect to Atmosphere" modal as they're identical - we can split them again later if it makes sense 🙏
|
Thanks for your first contribution, @ascorbic! 🎊 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
|
Keep in mind that prompt of create isn't part of the OAuth spec yet for at protocol, so it'll probably only work with the reference implementation (you can discover this via the AS metadata) |
good to know! if we switch out the underlying PDS impl in the future we can always change the logic to match |
🔗 Linked issue
#3021
🧭 Context
The current /pds page only has a link to PDS MOOver, with no way to directly create a new account. To create a new account (rather than migrating) a user needs to open the "Connect" menu, select "Connect to Atmosphere", then click the button in the modal.
📚 Description
This PR adds a button alongside the PDS Moover one that calls
authRedirectin the same way as the equivalent in the modal.