Skip to content

test: add e2e test for top level/root package redirects - #3124

Merged
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:e2e-shorthand-package-url
Aug 3, 2026
Merged

test: add e2e test for top level/root package redirects#3124
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:e2e-shorthand-package-url

Conversation

@gameroman

@gameroman gameroman commented Aug 3, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

Follow up to #3122

🧭 Context

📚 Description

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview Aug 3, 2026 7:00pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Aug 3, 2026 7:00pm
npmx-lunaria Ignored Ignored Aug 3, 2026 7:00pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Added end-to-end coverage confirming that short package URLs resolve to their canonical routes.
    • Verified that the expected package names are displayed after navigation.

Walkthrough

The end-to-end suite now checks canonical redirects for /vue and /@nuxt/kit. It also verifies the resulting browser URLs and package headings.

Changes

URL compatibility

Layer / File(s) Summary
Root package redirect coverage
test/e2e/url-compatibility.spec.ts
Added tests for unscoped and scoped root package URLs. The tests assert canonical /package/... URLs and the expected package names.
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description links an issue but contains only an uncompleted template and no meaningful summary of the test changes. Add a brief summary of the end-to-end tests for /vue and /@nuxt/kit package short-URL redirects.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the addition of an end-to-end test for top-level package redirects.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gameroman
gameroman enabled auto-merge August 3, 2026 19:03
@gameroman
gameroman requested a review from a team August 3, 2026 19:03
@ghostdevv ghostdevv changed the title chore: add e2e test for Package Short-URLs test: add e2e test for package root redirect Aug 3, 2026
@ghostdevv ghostdevv changed the title test: add e2e test for package root redirect test: add e2e test for top level/root package redirects Aug 3, 2026
@gameroman
gameroman added this pull request to the merge queue Aug 3, 2026
Merged via the queue into npmx-dev:main with commit 96fc513 Aug 3, 2026
28 checks passed
@gameroman
gameroman deleted the e2e-shorthand-package-url branch August 3, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants