chore(ui): add some storybook entries - #3141
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesStorybook now includes component stories, mock fixtures, decorators, controls, responsive examples, loading states, and autodocs metadata. The preview decorator applies the selected global theme class to the document root. Storybook component coverage
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Question for reviewer: do we need to have code coverage for stories? |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.storybook/preview.ts:
- Around line 76-78: Update the theme application logic around themeClass so it
assigns the derived light/dark value to document.documentElement.dataset.theme,
matching the selectors in main.css. Remove the light/dark class removal and
addition unless another Storybook stylesheet explicitly requires those classes.
In `@app/components/PaginationControls.stories.ts`:
- Around line 16-33: Synchronize the local refs in the PaginationControls
story’s render setup with Storybook args after initialization. Add watchers for
args.mode, args.pageSize, and args.currentPage that update the corresponding
mode, pageSize, and currentPage refs when control-panel values change, while
preserving the existing v-model bindings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fc7b6132-12f5-4301-8e0d-8b7b782bc038
📒 Files selected for processing (23)
.storybook/preview.tsapp/components/About/GovernanceList.stories.tsapp/components/About/LogoImg.stories.tsapp/components/About/LogoList.stories.tsapp/components/Alert.stories.tsapp/components/BaseCard.stories.tsapp/components/Brand/Customize.stories.tsapp/components/Code/DirectoryListing.stories.tsapp/components/Code/FileTree.stories.tsapp/components/Code/Header.stories.tsapp/components/Code/MobileTreeDrawer.stories.tsapp/components/Code/SkeletonLoader.stories.tsapp/components/Code/Viewer.stories.tsapp/components/CollapsibleSection.stories.tsapp/components/CopyToClipboardButton.stories.tsapp/components/Input/Base.stories.tsapp/components/Link/Link.stories.tsapp/components/LoadingSpinner.stories.tsapp/components/PaginationControls.stories.tsapp/components/ProgressBar.stories.tsapp/components/ProvenanceBadge.stories.tsapp/components/SkeletonBlock.stories.tsapp/components/SkeletonInline.stories.ts
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
serhalp
left a comment
There was a problem hiding this comment.
Amazing, thank you for contributing!
🔗 Linked issue
fixes some of #1841
🧭 Context
If desired, I can scaffold the stories for the remaining components, but I'd like to know if this is the direction you want to take.
I also think that it could be nice to organize the components a bit more, to store some core UI components separate from specific features. This will also help with storybook organization, as it should mirror the repo structure.
📚 Description