perf: use shallowRef and useTemplateRef
#476
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
| const popupEl = ref<HTMLElement | null>(null) | ||
| const popupEl = useTemplateRef('popupEl') | ||
| const popupPosition = shallowRef<{ top: number; left: number } | null>(null) | ||
|
|
||
| // Function ref - captures the element when popup mounts | ||
| function setPopupRef(el: unknown) { | ||
| popupEl.value = (el as HTMLElement) || null | ||
| } | ||
|
|
There was a problem hiding this comment.
@Flo0806 was there a reason to use a setter here? from my tests conditional useTemplateRef works fine with onClickOutside 😅
There was a problem hiding this comment.
I had some problems, yes. But if it works for you - perfect. Your way is the better
There was a problem hiding this comment.
If you can still reproduce the bug we might be able to fix it upstream (vueuse or vue)
There was a problem hiding this comment.
No... I think I had just to restart the dev server...
|
we should create an eslint rule |
I also thought about this. I think we have an lint rule at vueuse that |
|
Not sure how to migrate this to oxlint |
3 participants
Replacing some refs with shallowRefs