Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts mobile layout styles to better accommodate longer translated labels and to prevent header links from overflowing / causing horizontal scroll.
Changes:
- Add a minimum width constraint to the header search input to avoid overly narrow rendering on small screens.
- Make header right-side controls wrap and increase link hitboxes via padding.
- Allow footer links to wrap on smaller viewports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/components/SearchBox.vue | Adds a minimum width utility to the search input for better mobile reflow. |
| app/components/AppHeader.vue | Adjusts header sizing/wrapping and increases header link hitboxes for mobile. |
| app/components/AppFooter.vue | Enables wrapping for footer links to prevent overflow with longer labels. |
Member
|
great! I think we should also have less vertical height when the links wrap in the footer |
With new translations coming in, some UI quirks become visible. This fixes several issues with UI not reflowing correctly when longer-than-english labels were used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With new translations coming in, some UI quirks become visible. This fixes several issues with UI not reflowing correctly when longer-than-english labels were used.
Additionally, links in header gathered bigger hitbox to match account-menu and to make aligning them even possible.
Before (BAD):
After (AMAZING):
Before (BAD):
☝️ This is worse than it seems from the white-on-white screenshot but the links are overflowing on the right causing the page to gain horizontal scroll on mobile
After (AMAZING):