perf: use $fetch.raw instead fetch with separate controller + timeout#485
Merged
danielroe merged 6 commits intonpmx-dev:mainfrom Jan 31, 2026
Merged
perf: use $fetch.raw instead fetch with separate controller + timeout#485danielroe merged 6 commits intonpmx-dev:mainfrom
$fetch.raw instead fetch with separate controller + timeout#485danielroe merged 6 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
OrbisK
commented
Jan 31, 2026
| headers: { | ||
| 'Accept': 'application/vnd.github.v3+json', | ||
| 'User-Agent': 'npmx.dev', | ||
| 'User-Agent': 'npmx', |
Contributor
Author
There was a problem hiding this comment.
every other user-agent is npmx not npmx.dev
Contributor
Author
|
Tests are failing. I will take a look |
auto-merge was automatically disabled
January 31, 2026 16:04
Head branch was pushed to by a user without write access
Contributor
Author
|
@danielroe Okay. I was super confused becaused it worked locally. But it was cached all the time. 😅 I think this might be a ofetch bug (or at least a type issue). The problem is here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know these are micro-optimisations. Initially I was looking to see if every timeout was cleaned up properly.