chore: use oxlint and oxfmt directly #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the vite-plus dependency for linting and formatting operations to avoid a performance bug where postinstall scripts run on every vite-plus command. The change reduces command execution time by approximately 4.5 seconds.
Changes:
- Replaced
vite lintandvite fmtcommands with direct calls tooxlintandoxfmt - Added explicit dependencies for
oxlintandoxfmtpackages - Updated lint-staged configuration to use the new command patterns
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Due to a bug in vite-plus, every vite-plus command runs postinstall, consequently taking much longer than anticipated. The outcome of this is that commands like `pnpm lint` and perhaps even worse, `git commit` are about 4.5 seconds slower than they could. This PR fixes that by directly calling oxlint and oxfmt, circumventing the issue.
wojtekmaj
force-pushed
the
faster-lint-staged
branch
from
795c86d to
a51b6e9
Compare
danielroe
changed the title
danielroe
approved these changes
Feb 2, 2026
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in vite-plus, every vite-plus command runs postinstall, consequently taking much longer than anticipated. The outcome of this is that commands like
pnpm lintand perhaps even worse,git commitare about 4.5 seconds slower than they could. This PR fixes that by directly calling oxlint and oxfmt, circumventing the issue.