Skip to content

Conversation

@wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Feb 3, 2026

🍃 Eco friendly PR
Estimated 4665 kg CO₂e savings per year
Calculations: ci_arm64_co2e_savings_with_speedup.xlsx

Comparing, (before/after; take into consideration missing cache) it seems to shave off:

  • ~2 seconds from tsc
  • ~2 seconds from unit tests
  • ~6 seconds from components tests
  • ~2 seconds from browser tests
    leaving the rest pretty much intact.

Copilot AI review requested due to automatic review settings February 3, 2026 10:43
@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 11:05pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 3, 2026 11:05pm
npmx-lunaria Ignored Ignored Feb 3, 2026 11:05pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows to run CI jobs on Ubuntu 24.04 ARM runners to improve performance and reduce cost.

Changes:

  • Switch runs-on from ubuntu-latest to ubuntu-24.04-arm in the main CI workflow.
  • Switch runs-on from ubuntu-latest to ubuntu-24.04-arm in the autofix workflow.
  • Switch runs-on from ubuntu-latest to ubuntu-24.04-arm in the Lunaria overview workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Moves lint/test/browser/a11y/knip jobs to Ubuntu 24.04 ARM runners.
.github/workflows/autofix.yml Moves the autofix job to an Ubuntu 24.04 ARM runner.
.github/workflows/lunaria.yml Moves Lunaria overview generation to an Ubuntu 24.04 ARM runner.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

This pull request updates three GitHub Actions workflows to change CI runner images. The autofix, CI and lunaria workflows have their runs-on values modified from ubuntu-latest to ubuntu-24.04-arm for the listed jobs; the a11y job in the CI workflow remains on ubuntu-latest. No changes were made to steps, commands or job logic. Total line-level edits are small (each workflow shows one or a few additions and deletions).

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, explaining the motivation (environmental savings and performance improvements) and providing concrete measurements of the impact.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@wojtekmaj
Copy link
Contributor Author

Actual difference in CI run time minuscule, a bit wobbly because of caching that didn't settle down just yet. Up to you whether to merge or not.

@serhalp
Copy link
Collaborator

serhalp commented Feb 3, 2026

There's also these new runners we could try for some of the lightweight workflows? https://github.blog/changelog/2026-01-22-1-vcpu-linux-runner-now-generally-available-in-github-actions/

@wojtekmaj
Copy link
Contributor Author

wojtekmaj commented Feb 3, 2026

There's also these new runners we could try for some of the lightweight workflows? https://github.blog/changelog/2026-01-22-1-vcpu-linux-runner-now-generally-available-in-github-actions/

Interesting, but it seems like a cost saving opportunity, which in our case is not a concern. Or is it?

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete. 🔄️
lunaria/files/fr-FR.json Localization changed, will be marked as complete. 🔄️
lunaria/files/ja-JP.json Localization changed, will be marked as complete. 🔄️
lunaria/files/pl-PL.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

From my experience, this gives ~20% performance boost, while being 17% cheaper.
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@danielroe
Copy link
Member

as a public repo, we're not paying for actions

@wojtekmaj wojtekmaj marked this pull request as ready for review February 3, 2026 23:14
@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into npmx-dev:main with commit d4584fe Feb 3, 2026
18 checks passed
@wojtekmaj wojtekmaj deleted the arm branch February 3, 2026 23:30
iiio2 added a commit to iiio2/npmx.dev that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants