chore: remove direct dependency on playwright-core#898
chore: remove direct dependency on playwright-core#898danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
@playwright/test was already pulling playwright-core in, and its version is 1.58.1. On top of that, we pulled in 1.58.0 - unnecessarily adding ~9 MB download
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughThis change removes the development dependency "playwright-core" version 1.58.0 from the package.json file. The modification represents a single line removal with no other alterations to the project configuration. No functional changes or public API modifications are introduced by this adjustment. Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant direct dependency on playwright-core version 1.58.0. Since @playwright/test@1.58.1 already includes playwright@1.58.1, which in turn depends on playwright-core@1.58.1, the direct dependency was unnecessary and resulted in downloading both versions (1.58.0 and 1.58.1), adding approximately 9 MB of unnecessary downloads.
Changes:
- Removed
playwright-core1.58.0 from devDependencies in package.json - Updated all pnpm-lock.yaml references from
playwright-core@1.58.0toplaywright-core@1.58.1to use the version provided transitively through@playwright/test
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed the direct playwright-core 1.58.0 devDependency |
| pnpm-lock.yaml | Updated all dependency references to use playwright-core@1.58.1 provided transitively by @playwright/test@1.58.1 -> playwright@1.58.1 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@playwright/test was already pulling playwright-core in, and its version is 1.58.1. On top of that, we pulled in 1.58.0 - unnecessarily adding ~9 MB download