Skip to content

chore: remove direct dependency on playwright-core#898

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:no-playwright-core
Feb 4, 2026
Merged

chore: remove direct dependency on playwright-core#898
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:no-playwright-core

Conversation

@wojtekmaj
Copy link
Contributor

@playwright/test was already pulling playwright-core in, and its version is 1.58.1. On top of that, we pulled in 1.58.0 - unnecessarily adding ~9 MB download

@playwright/test was already pulling playwright-core in, and its version is 1.58.1. On top of that, we pulled in 1.58.0 - unnecessarily adding ~9 MB download
Copilot AI review requested due to automatic review settings February 4, 2026 00:02
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Error Error Feb 4, 2026 0:04am
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 0:04am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 4, 2026 0:04am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This change removes the development dependency "playwright-core" version 1.58.0 from the package.json file. The modification represents a single line removal with no other alterations to the project configuration. No functional changes or public API modifications are introduced by this adjustment.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the rationale for removing the playwright-core dependency, including the redundancy and the ~9 MB space saving.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant direct dependency on playwright-core version 1.58.0. Since @playwright/test@1.58.1 already includes playwright@1.58.1, which in turn depends on playwright-core@1.58.1, the direct dependency was unnecessary and resulted in downloading both versions (1.58.0 and 1.58.1), adding approximately 9 MB of unnecessary downloads.

Changes:

  • Removed playwright-core 1.58.0 from devDependencies in package.json
  • Updated all pnpm-lock.yaml references from playwright-core@1.58.0 to playwright-core@1.58.1 to use the version provided transitively through @playwright/test

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Removed the direct playwright-core 1.58.0 devDependency
pnpm-lock.yaml Updated all dependency references to use playwright-core@1.58.1 provided transitively by @playwright/test@1.58.1 -> playwright@1.58.1
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 8abd52e Feb 4, 2026
21 of 23 checks passed
@wojtekmaj wojtekmaj deleted the no-playwright-core branch February 4, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants